[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 8/8] qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostV
From: |
Stefan Hajnoczi |
Subject: |
[PULL 8/8] qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa |
Date: |
Thu, 1 Jun 2023 11:25:52 -0400 |
From: Stefano Garzarella <sgarzare@redhat.com>
The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the fd
passing through the new 'fd' property.
Since now we are using qemu_open() on '@path' if the virtio-blk driver
supports the fd passing, let's announce it.
In this way, the management layer can pass the file descriptor of an
already opened vhost-vdpa character device. This is useful especially
when the device can only be accessed with certain privileges.
Add the '@fdset' feature only when the virtio-blk-vhost-vdpa driver
in libblkio supports it.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20230530071941.8954-3-sgarzare@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
qapi/block-core.json | 6 ++++++
meson.build | 4 ++++
2 files changed, 10 insertions(+)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 98d9116dae..4bf89171c6 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3955,10 +3955,16 @@
#
# @path: path to the vhost-vdpa character device.
#
+# Features:
+# @fdset: Member @path supports the special "/dev/fdset/N" path
+# (since 8.1)
+#
# Since: 7.2
##
{ 'struct': 'BlockdevOptionsVirtioBlkVhostVdpa',
'data': { 'path': 'str' },
+ 'features': [ { 'name' :'fdset',
+ 'if': 'CONFIG_BLKIO_VHOST_VDPA_FD' } ],
'if': 'CONFIG_BLKIO' }
##
diff --git a/meson.build b/meson.build
index bc76ea96bf..a61d3e9b06 100644
--- a/meson.build
+++ b/meson.build
@@ -2106,6 +2106,10 @@ config_host_data.set('CONFIG_LZO', lzo.found())
config_host_data.set('CONFIG_MPATH', mpathpersist.found())
config_host_data.set('CONFIG_MPATH_NEW_API', mpathpersist_new_api)
config_host_data.set('CONFIG_BLKIO', blkio.found())
+if blkio.found()
+ config_host_data.set('CONFIG_BLKIO_VHOST_VDPA_FD',
+ blkio.version().version_compare('>=1.3.0'))
+endif
config_host_data.set('CONFIG_CURL', curl.found())
config_host_data.set('CONFIG_CURSES', curses.found())
config_host_data.set('CONFIG_GBM', gbm.found())
--
2.40.1
- [PULL 0/8] Block patches, Stefan Hajnoczi, 2023/06/01
- [PULL 2/8] block/nvme: convert to blk_io_plug_call() API, Stefan Hajnoczi, 2023/06/01
- [PULL 4/8] block/io_uring: convert to blk_io_plug_call() API, Stefan Hajnoczi, 2023/06/01
- [PULL 3/8] block/blkio: convert to blk_io_plug_call() API, Stefan Hajnoczi, 2023/06/01
- [PULL 8/8] qapi: add '@fdset' feature for BlockdevOptionsVirtioBlkVhostVdpa,
Stefan Hajnoczi <=
- [PULL 7/8] block/blkio: use qemu_open() to support fd passing for virtio-blk, Stefan Hajnoczi, 2023/06/01
- [PULL 5/8] block/linux-aio: convert to blk_io_plug_call() API, Stefan Hajnoczi, 2023/06/01
- [PULL 6/8] block: remove bdrv_co_io_plug() API, Stefan Hajnoczi, 2023/06/01
- [PULL 1/8] block: add blk_io_plug_call() API, Stefan Hajnoczi, 2023/06/01
- Re: [PULL 0/8] Block patches, Richard Henderson, 2023/06/01