qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 03/10] tests/qtest: get rid of 'qmp_command' helper in mig


From: Thomas Huth
Subject: Re: [PATCH v4 03/10] tests/qtest: get rid of 'qmp_command' helper in migration test
Date: Fri, 2 Jun 2023 09:52:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 01/06/2023 18.13, Daniel P. Berrangé wrote:
This function duplicates logic of qtest_qmp_assert_success_ref.
The qtest_qmp_assert_success_ref method has better diagnostics
on failure because it prints the entire QMP response, instead
of just asserting on existance of the 'error' key.

Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  tests/qtest/migration-helpers.c | 22 ----------------------
  tests/qtest/migration-helpers.h |  3 ---
  tests/qtest/migration-test.c    | 29 +++++++++++++++--------------
  3 files changed, 15 insertions(+), 39 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]