[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/10] qtest/migration: Document live=true cases
From: |
Juan Quintela |
Subject: |
[PULL 10/10] qtest/migration: Document live=true cases |
Date: |
Fri, 2 Jun 2023 12:49:10 +0200 |
From: Peter Xu <peterx@redhat.com>
Document every single live=true use cases on why it should be done in the
live manner. Also document on the parameter so new precopy cases should
always use live=off unless with explicit reasonings.
Cc: Thomas Huth <thuth@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>
Cc: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20230601172935.175726-1-peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
tests/qtest/migration-test.c | 37 ++++++++++++++++++++++++++++++------
1 file changed, 31 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 0b9d045152..b0c355bbd9 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -580,7 +580,14 @@ typedef struct {
/* Optional: set number of migration passes to wait for, if live==true */
unsigned int iterations;
- /* Optional: whether the guest CPUs should be running during migration */
+ /*
+ * Optional: whether the guest CPUs should be running during a precopy
+ * migration test. We used to always run with live but it took much
+ * longer so we reduced live tests to only the ones that have solid
+ * reason to be tested live-only. For each of the new test cases for
+ * precopy please provide justifications to use live explicitly (please
+ * refer to existing ones with live=true), or use live=off by default.
+ */
bool live;
/* Postcopy specific fields */
@@ -1491,7 +1498,10 @@ static void test_precopy_unix_plain(void)
MigrateCommon args = {
.listen_uri = uri,
.connect_uri = uri,
-
+ /*
+ * The simplest use case of precopy, covering smoke tests of
+ * get-dirty-log dirty tracking.
+ */
.live = true,
};
@@ -1508,7 +1518,10 @@ static void test_precopy_unix_dirty_ring(void)
},
.listen_uri = uri,
.connect_uri = uri,
-
+ /*
+ * Besides the precopy/unix basic test, cover dirty ring interface
+ * rather than get-dirty-log.
+ */
.live = true,
};
@@ -1617,10 +1630,12 @@ static void test_precopy_unix_xbzrle(void)
MigrateCommon args = {
.connect_uri = uri,
.listen_uri = uri,
-
.start_hook = test_migrate_xbzrle_start,
-
.iterations = 2,
+ /*
+ * XBZRLE needs pages to be modified when doing the 2nd+ round
+ * iteration to have real data pushed to the stream.
+ */
.live = true,
};
@@ -1639,6 +1654,11 @@ static void test_precopy_unix_compress(void)
* the previous iteration.
*/
.iterations = 2,
+ /*
+ * We make sure the compressor can always work well even if guest
+ * memory is changing. See commit 34ab9e9743 where we used to fix
+ * a bug when only trigger-able with guest memory changing.
+ */
.live = true,
};
@@ -1657,6 +1677,7 @@ static void test_precopy_unix_compress_nowait(void)
* the previous iteration.
*/
.iterations = 2,
+ /* Same reason for the wait version of precopy compress test */
.live = true,
};
@@ -2066,7 +2087,11 @@ static void test_multifd_tcp_none(void)
MigrateCommon args = {
.listen_uri = "defer",
.start_hook = test_migrate_precopy_tcp_multifd_start,
-
+ /*
+ * Multifd is more complicated than most of the features, it
+ * directly takes guest page buffers when sending, make sure
+ * everything will work alright even if guest page is changing.
+ */
.live = true,
};
test_precopy_common(&args);
--
2.40.1
- [PULL 00/10] Migration 20230602 patches, Juan Quintela, 2023/06/02
- [PULL 01/10] tests/qtest: add various qtest_qmp_assert_success() variants, Juan Quintela, 2023/06/02
- [PULL 02/10] tests/qtest: add support for callback to receive QMP events, Juan Quintela, 2023/06/02
- [PULL 04/10] tests/qtest: get rid of some 'qtest_qmp' usage in migration test, Juan Quintela, 2023/06/02
- [PULL 07/10] tests/qtest: capture RESUME events during migration, Juan Quintela, 2023/06/02
- [PULL 06/10] tests/qtest: replace wait_command() with qtest_qmp_assert_success, Juan Quintela, 2023/06/02
- [PULL 08/10] tests/qtest: distinguish src/dst migration VM stop/resume events, Juan Quintela, 2023/06/02
- [PULL 10/10] qtest/migration: Document live=true cases,
Juan Quintela <=
- [PULL 09/10] tests/qtest: make more migration pre-copy scenarios run non-live, Juan Quintela, 2023/06/02
- [PULL 05/10] tests/qtest: switch to using event callbacks for STOP event, Juan Quintela, 2023/06/02
- [PULL 03/10] tests/qtest: get rid of 'qmp_command' helper in migration test, Juan Quintela, 2023/06/02
- Re: [PULL 00/10] Migration 20230602 patches, Richard Henderson, 2023/06/02