Re: [PATCH] Add virtio-sound and virtio-sound-pci devices

[Manos Pitsidianakis]

On Wed, 31 May 2023 12:36, Alex Bennée <alex.bennee@linaro.org> wrote:
> If it's based of shouldn't we keep the author attribution and their
> original s-o-b?

I kept the Copyright in the headers but not the Signed-off-by lines, 
I'll add them in v2.


> What about:
>
>  
> https://patchew.org/QEMU/20220211221319.193404-1-chouhan.shreyansh2702@gmail.com/
>
> (which is also much more nicely split up).

Comments in that thread were:

> IMHO, all your patches can be merged in only one

and

> Possibly also patches adding
> significant functionality in the future (i.e. one patch with all
> basics and playback support, one patch adding recording
> functionality, ...).

which is why capture was left unimplemented for a future patch:

> > +
> > +    } else {
> > +        /*
> > +         * Unimplemented.
> > +         * stream->voice.in = AUD_open_in(&s->card,
> > +         *                                stream->voice.in,
> > +         *                                "virtio_snd_card",
> > +         *                                stream,
> > +         *                                virtio_snd_input_cb,
> > +         *                                &as);
> > +         */
>
>  qemu_log(LOG_UNIMP, ) - although why not implement it?
>
> > +    }