qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v2] linux-user/riscv: Add syscall riscv_hwprobe


From: Andrew Jones
Subject: Re: [RFC v2] linux-user/riscv: Add syscall riscv_hwprobe
Date: Fri, 2 Jun 2023 17:07:01 +0200

On Fri, Jun 02, 2023 at 04:39:20PM +0200, Robbin Ehn wrote:
> On Fri, 2023-06-02 at 16:02 +0200, Andrew Jones wrote:
> > On Fri, Jun 02, 2023 at 11:41:11AM +0200, Robbin Ehn wrote:
...
> > > +#if defined(TARGET_RISCV)
> > > +    case TARGET_NR_riscv_hwprobe:
> > > +        {
> > 
> > The { goes under the c of case, which will shift all the below four spaces
> > left as well.
> 
> This was an attempt to blend in, i.e. same style as the preceding case.
> I'll change, thanks.

Hmm, I see. This function does have many cases with the indented format,
but not all of them, and the rest of the code base doesn't indent. I won't
insist on changing this, as long as checkpatch isn't complaining.

Thanks,
drew



reply via email to

[Prev in Thread] Current Thread [Next in Thread]