qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 2/2] bulk: Replace !CONFIG_USER_ONLY -> CONFIG_SOFTMMU


From: Philippe Mathieu-Daudé
Subject: Re: [RFC PATCH 2/2] bulk: Replace !CONFIG_USER_ONLY -> CONFIG_SOFTMMU
Date: Sat, 3 Jun 2023 00:59:47 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 3/6/23 00:58, Philippe Mathieu-Daudé wrote:
CONFIG_SOFTMMU is the opposite of CONFIG_USER_ONLY.
Now that CONFIG_SOFTMMU isn't poisoined anymore,
replace !CONFIG_USER_ONLY negation by the positive
form which is clearer when reviewing code.

Change mostly done mechanically using:

   $ sed -i -e 's/ifndef CONFIG_USER_ONLY/ifdef CONFIG_SOFTMMU/' \
            -e 's/!defined(CONFIG_USER_ONLY)/defined(CONFIG_SOFTMMU)/' \
                $(git grep -l CONFIG_USER_ONLY)

and adapting comments manually.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  scripts/coccinelle/round.cocci                |   6 +


diff --git a/scripts/coccinelle/round.cocci b/scripts/coccinelle/round.cocci
index ed06773289..0a27b6da4d 100644
--- a/scripts/coccinelle/round.cocci
+++ b/scripts/coccinelle/round.cocci
@@ -17,3 +17,9 @@ expression e2;
  @@
  -(DIV_ROUND_UP(e1,e2))
  +DIV_ROUND_UP(e1,e2)
+
+@@
+expression n, d;
+@@
+-   n & ~(d - 1)
++   ROUND_DOWN(n, d)

Oops, unrelated =)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]