qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 47/48] exec/poison: Do not poison CONFIG_SOFTMMU


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 47/48] exec/poison: Do not poison CONFIG_SOFTMMU
Date: Sat, 3 Jun 2023 01:15:02 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 31/5/23 06:03, Richard Henderson wrote:
If CONFIG_USER_ONLY is ok generically, so is CONFIG_SOFTMMU,
because they are exactly opposite.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  include/exec/poison.h         | 1 -
  scripts/make-config-poison.sh | 5 +++--
  2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/exec/poison.h b/include/exec/poison.h
index 256736e11a..e94ee8dfef 100644
--- a/include/exec/poison.h
+++ b/include/exec/poison.h
@@ -85,7 +85,6 @@
  #pragma GCC poison CONFIG_HVF
  #pragma GCC poison CONFIG_LINUX_USER
  #pragma GCC poison CONFIG_KVM
-#pragma GCC poison CONFIG_SOFTMMU
  #pragma GCC poison CONFIG_WHPX
  #pragma GCC poison CONFIG_XEN
diff --git a/scripts/make-config-poison.sh b/scripts/make-config-poison.sh
index 1892854261..2b36907e23 100755
--- a/scripts/make-config-poison.sh
+++ b/scripts/make-config-poison.sh
@@ -4,11 +4,12 @@ if test $# = 0; then
    exit 0
  fi
-# Create list of config switches that should be poisoned in common code...
-# but filter out CONFIG_TCG and CONFIG_USER_ONLY which are special.
+# Create list of config switches that should be poisoned in common code,
+# but filter out several which are handled manually.
  exec sed -n \
    -e' /CONFIG_TCG/d' \
    -e '/CONFIG_USER_ONLY/d' \
+  -e '/CONFIG_SOFTMMU/d' \
    -e '/^#define / {' \
    -e    's///' \
    -e    's/ .*//' \

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]