Re: [PATCH v3 24/48] tcg: Split helper-proto.h

[Richard Henderson]

On 6/2/23 14:14, Philippe Mathieu-Daudé wrote:
> On 31/5/23 06:03, Richard Henderson wrote:
> > Create helper-proto-common.h without the target specific portion.
> > Use that in tcg-op-common.h.  Include helper-proto.h in target/arm
> > and target/hexagon before helper-info.c.inc; all other targets are
> > already correct in this regard.
> >
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   include/exec/helper-proto-common.h | 17 +++++++
> >   include/exec/helper-proto.h        | 72 ++++--------------------------
> >   include/tcg/tcg-op-common.h        |  2 +-
> >   include/exec/helper-proto.h.inc    | 67 +++++++++++++++++++++++++++
> >   accel/tcg/cputlb.c                 |  3 +-
> >   accel/tcg/plugin-gen.c             |  2 +-
> >   accel/tcg/tcg-runtime-gvec.c       |  2 +-
> >   accel/tcg/tcg-runtime.c            |  2 +-
> >   target/arm/tcg/translate.c         |  1 +
> >   target/hexagon/translate.c         |  1 +
> >   10 files changed, 99 insertions(+), 70 deletions(-)
> >   create mode 100644 include/exec/helper-proto-common.h
> >   create mode 100644 include/exec/helper-proto.h.inc
>
>
> > diff --git a/include/exec/helper-proto.h.inc b/include/exec/helper-proto.h.inc
> > new file mode 100644
> > index 0000000000..f6f0cfcacd
> > --- /dev/null
> > +++ b/include/exec/helper-proto.h.inc
...

> Should we guard this header for multiple inclusions?

No, *.h.inc again.


r~