Re: [PATCH v2 21/23] q800: move macfb device to Q800MachineState

[Mark Cave-Ayland]

On 31/05/2023 14:55, Philippe Mathieu-Daudé wrote:

> On 31/5/23 14:53, Mark Cave-Ayland wrote:
> > Also change the instantiation of the macfb device to use 
> > object_initialize_child().
> >
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> > ---
> >   hw/m68k/q800.c         | 6 ++++--
> >   include/hw/m68k/q800.h | 2 ++
> >   2 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c
> > index 946cb09e30..0e7451e77a 100644
> > --- a/hw/m68k/q800.c
> > +++ b/hw/m68k/q800.c
> > @@ -449,7 +449,9 @@ static void q800_machine_init(MachineState *machine)
> >       /* framebuffer in nubus slot #9 */
> > -    dev = qdev_new(TYPE_NUBUS_MACFB);
> > +    object_initialize_child(OBJECT(machine), "macfb", &m->macfb,
>
> Alternatively "framebuffer" or "fb". Regardless,

I'd prefer to keep this as macfb if possible, simply because it matches the 
convention of using the device type as the basis for the object child property name 
throughout the series.

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> > +                            TYPE_NUBUS_MACFB);


ATB,

Mark.