qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/mips/malta: Fix the malta machine on big endian hosts


From: Thomas Huth
Subject: Re: [PATCH] hw/mips/malta: Fix the malta machine on big endian hosts
Date: Mon, 5 Jun 2023 08:20:46 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 31/05/2023 09.13, Thomas Huth wrote:
On 09/05/2023 20.44, Peter Maydell wrote:
On Thu, 13 Apr 2023 at 17:26, Peter Maydell <peter.maydell@linaro.org> wrote:

On Thu, 13 Apr 2023 at 17:08, Michael Tokarev <mjt@tls.msk.ru> wrote:

30.03.2023 18:26, Thomas Huth wrote:
Booting a Linux kernel with the malta machine is currently broken
on big endian hosts. The cpu_to_gt32 macro wants to byteswap a value
for little endian targets only, but uses the wrong way to do this:
cpu_to_[lb]e32 works the other way round on big endian hosts! Fix
it by using the same ways on both, big and little endian hosts.

Fixes: 0c8427baf0 ("hw/mips/malta: Use bootloader helper to set BAR registers")
Signed-off-by: Thomas Huth <thuth@redhat.com>

Has this been forgotten?

Looks like it. Too late for 8.0 now (and it wasn't a regression
since it looks like it was broken in 7.2 as well); will have to
be fixed in 8.1.

Philippe -- looks like this patch still hasn't been queued ?
(It could probably use a Cc: qemu-stable@nongnu.org at this point.)

It can have my
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

*ping*

Philippe, can you please comment? I think this should be good enough at least for a temporary fix, even if you have more clean ups in this area in mind later...

Philippe, if you don't mind, I'll take this through my s390x tree since this fixes a problem on the big-endian s390x hosts.

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]