Re: [PATCH v2] meson.build: Use -Wno-undef only for SDL2 versions that need it

[Paolo Bonzini]

On 6/5/23 11:05, Paolo Bonzini wrote:
> > On 05/06/2023 10.27, Paolo Bonzini wrote:
> > > Queued, thanks.
> >
> > Please unqueue it again, I'm still seeing some issues with the patch 
> > (not sure why yet):
> >
> > https://gitlab.com/thuth/qemu/-/jobs/4411089009
>
> Yeah, noticed that myself now. 😄

I think all you need is:

diff --git a/meson.build b/meson.build
index 025523f2065..3ec35c96fea 100644
--- a/meson.build
+++ b/meson.build
@@ -1345,7 +1345,7 @@ if sdl.found()
                      #include <SDL.h>
                      #include <SDL_syswm.h>
                      int main(int argc, char *argv[]) { return 0; }
-                     ''', dependencies: sdl, args: '-Wundef')
+                     ''', dependencies: sdl, args: ['-Wundef', '-Werror'])
     sdl = declare_dependency(compile_args: '-Wno-undef',
                              dependencies: sdl,
                              version: sdl.version())

Paolo