Re: [PATCH 08/10] meson: subprojects: replace berkeley-{soft,test}float-3 with wraps

[Daniel P . Berrangé]

On Mon, Jun 05, 2023 at 11:52:21AM +0200, Paolo Bonzini wrote:
> Unlike other subprojects, these require an overlay directory to include
> meson rules to build the libraries.  The rules are basically lifted
> from tests/fp/meson.build, with a few changes to create platform.h
> and publish a dependency.
> 
> The build defines are passed through a subproject option, and posted
> back to users of the library via the dependency's compile_args.
> 
> The only remaining user of GIT_SUBMODULES and GIT_SUBMODULES_ACTION
> is roms/SLOF, which is used to build pc-bios/s390-ccw.  All other
> roms submodules are only present to satisfy the license on pre-built
> firmware blobs.
> 
> Best reviewed with --color-moved.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  .gitmodules                                   |   6 -
>  configure                                     |  27 -
>  scripts/archive-source.sh                     |  22 +-
>  scripts/make-release                          |   2 +-
>  subprojects/.gitignore                        |   2 +
>  subprojects/berkeley-softfloat-3.wrap         |   5 +
>  subprojects/berkeley-testfloat-3.wrap         |   5 +
>  .../berkeley-softfloat-3/meson.build          | 339 +++++++++++
>  .../berkeley-softfloat-3/meson_options.txt    |   1 +
>  .../berkeley-testfloat-3/meson.build          | 220 +++++++
>  .../berkeley-testfloat-3/meson_options.txt    |   1 +
>  tests/fp/meson.build                          | 541 +-----------------
>  12 files changed, 590 insertions(+), 581 deletions(-)
>  create mode 100644 subprojects/berkeley-softfloat-3.wrap
>  create mode 100644 subprojects/berkeley-testfloat-3.wrap
>  create mode 100644 subprojects/packagefiles/berkeley-softfloat-3/meson.build
>  create mode 100644 
> subprojects/packagefiles/berkeley-softfloat-3/meson_options.txt
>  create mode 100644 subprojects/packagefiles/berkeley-testfloat-3/meson.build
>  create mode 100644 
> subprojects/packagefiles/berkeley-testfloat-3/meson_options.txt

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|