qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw: Fix format for comments


From: Igor Mammedov
Subject: Re: [PATCH] hw: Fix format for comments
Date: Tue, 6 Jun 2023 15:29:49 +0200

On Mon, 15 May 2023 03:25:25 -0400
Shaoqin Huang <shahuang@redhat.com> wrote:

> Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments.

> Since
> we are at here, resort the parameters in comments to match the sequence
While at it, reorder ...
                   
> of parameters which defined in the CPUArchId.
> 
> CC: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>

with commit message fixed up
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  include/hw/boards.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index f4117fdb9a..cefa3d5897 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState 
> *machine,
>  /**
>   * CPUArchId:
>   * @arch_id - architecture-dependent CPU ID of present or possible CPU
> + * @vcpus_count - number of threads provided by @cpu object
> + * @props - CPU object properties, initialized by board
>   * @cpu - pointer to corresponding CPU object if it's present on NULL 
> otherwise
>   * @type - QOM class name of possible @cpu object
> - * @props - CPU object properties, initialized by board
> - * #vcpus_count - number of threads provided by @cpu object
>   */
>  typedef struct CPUArchId {
>      uint64_t arch_id;




reply via email to

[Prev in Thread] Current Thread [Next in Thread]