Re: [PATCH v4 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

[Suthikulpanit, Suravee]

Igor,

On 6/6/2023 3:11 PM, Igor Mammedov wrote:
> On Tue, 6 Jun 2023 09:35:41 +0200
> Igor Mammedov <imammedo@redhat.com> wrote:
>
> > On Mon, 5 Jun 2023 16:39:05 -0500
> > Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> wrote:
> [...]
> > > +    /* For pc-i44fx-8.0 and older, use SMBIOS 2.8 by default */
> > > +    pcmc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_32;
> > >   }
> [...]
> > >   static void pc_q35_8_0_machine_options(MachineClass *m)
> > >   {
> [...]
> > > +    /* For pc-q35-8.0 and older, use SMBIOS 2.8 by default */
> > > +    pcmc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_32;
> > >   }
> [...]
>
> what Michael referred to as duplication is probably these lines,
> however "smbios-entry-point-type: is machine property so we can't
> use device compat machinery here (pc_compat_8_0).
> What we can do is override "default_machine_opts" value, but then
> again it has to be opencoded in  piix4/q35_machine_options, so
> don't see a point in doing so.
> As you wrote here is what typically do for machine compat knobs,
> so it should be fine.

Ok

> I just doubt that we need extra default_smbios_ep_type field.

I introduce pcmc->default_smbios_ep_type because I could not get to 
pcms->smbios_entry_point_type from these functions. Any suggestions?

Anyhow, I'll send out v5 with some more clean up.

Thanks,
Suravee