Re: [PATCH] vdpa: fix not using CVQ buffer in case of error

[Lei Yang]

QE tested sanity testing for this patch on the vhost_vdpa device,
everything works fine.

Tested-by: Lei Yang <leiyang@redhat.com>


On Tue, Jun 6, 2023 at 9:32 AM Jason Wang <jasowang@redhat.com> wrote:
>
> On Sat, Jun 3, 2023 at 1:35 AM Eugenio Pérez <eperezma@redhat.com> wrote:
> >
> > Bug introducing when refactoring.  Otherway, the guest never received
> > the used buffer.
> >
> > Fixes: be4278b65fc1 ("vdpa: extract vhost_vdpa_net_cvq_add from 
> > vhost_vdpa_net_handle_ctrl_avail")
> > Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>
> Acked-by: Jason Wang <jasowang@redhat.com>
>
> Thanks
>
> > ---
> >  net/vhost-vdpa.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> > index 16d47f7b3c..5360924ba0 100644
> > --- a/net/vhost-vdpa.c
> > +++ b/net/vhost-vdpa.c
> > @@ -807,7 +807,7 @@ static int 
> > vhost_vdpa_net_handle_ctrl_avail(VhostShadowVirtqueue *svq,
> >      }
> >
> >      if (*s->status != VIRTIO_NET_OK) {
> > -        return VIRTIO_NET_ERR;
> > +        goto out;
> >      }
> >
> >      status = VIRTIO_NET_ERR;
> > --
> > 2.31.1
> >
>