[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2] migration: simplify blockers
From: |
Steven Sistare |
Subject: |
Re: [PATCH V2] migration: simplify blockers |
Date: |
Wed, 7 Jun 2023 10:13:32 -0400 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 |
On 2/7/2023 4:29 PM, Peter Xu wrote:
> On Tue, Feb 07, 2023 at 04:17:34PM -0500, Steven Sistare wrote:
>>>> + * *@reasonp is freed and set to NULL if failure is returned.
>>>> + * On success, the caller no longer owns *@reasonp and must not free it.
>>>
>>> This statement reads weird. IMHO the caller still owns @reasonp, but if it
>>> succeeded it should only free it with a migrate_del_blocker() later.
>>
>> How about:
>> On success, the caller must not free @reasonp, except by calling
>> migrate_del_blocker.
>
> LGTM, thanks.
>
Hi Peter, I will fix the comment, rebase, and repost.
Please consider upgrading your Acked-By to an RB.
- Steve
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH V2] migration: simplify blockers,
Steven Sistare <=