[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/3] configure: check for $download value properly
From: |
Paolo Bonzini |
Subject: |
[PULL 2/3] configure: check for $download value properly |
Date: |
Wed, 7 Jun 2023 17:47:23 +0200 |
From: Michal Privoznik <mprivozn@redhat.com>
If configure was invoked with --disable-download and git
submodules were not checked out a warning is produced and the
configure script fails. But the $download variable (which
reflects the enable/disable download argument) is checked for in
a weird fashion:
test -f "$download" = disabled
Drop the '-f' to check for the actual value of the variable.
Fixes: 2019cabfee0 ("meson: subprojects: replace submodules with wrap files",
2023-06-06)
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 8765b88e12f..8a638dd82ae 100755
--- a/configure
+++ b/configure
@@ -767,7 +767,7 @@ if test "$plugins" = "yes" -a "$tcg" = "disabled"; then
fi
if ! test -f "$source_path/subprojects/keycodemapdb/README" \
- && test -f "$download" = disabled
+ && test "$download" = disabled
then
echo
echo "ERROR: missing subprojects"
--
2.40.1