On Thu, 1 Jun 2023 at 19:48, Niek Linnenbank <nieklinnenbank@gmail.com> wrote:
>
> Hi Qianfan,
>
> Thanks for sending the v5. From my side, I have no further comments on the content.
> So please feel free to add the following to each of the patches 01-11 in the series:
>
> Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>
>
> As a reminder and explained here on this page, you'll need to make sure these lines gets added to each of the commit messages:
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review
>
> Doing so would require you to send another updated v6, and baselined on the latest master.
The rebase was simple, so I've applied this v5 to target-arm.next.
Great news!
(The patch application tools can pick up Reviewed-by tags that are
on-list without requiring a respin just for that.)
Ahh right, I wasn't aware of that. Thanks, I learned something new here.
Qianfan: thanks for working on this feature and for your efforts
in working through our patch review process.
Yes, great work indeed!
Niek: thanks very much for taking the lead on the patch review of
this series, it's been a tremendous help.
I'm glad to help. I only do qemu work in my spare time when I can, so it's not much.
But I enjoy doing it and learn something new in the process also.
Regards,
Niek
-- PMM