Re: [PATCH v5 2/3] hw/i386/pc: Default to use SMBIOS 3.0 for newer machine models

[Suthikulpanit, Suravee]

On 6/7/2023 8:49 PM, Igor Mammedov wrote:
> On Tue, 6 Jun 2023 21:49:38 -0500
> Suravee Suthikulpanit<suravee.suthikulpanit@amd.com>  wrote:
>
> ....
>
> and use this with the rest of your patch
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index b3d826a83a..c5bab28e9c 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1859,7 +1859,7 @@ static void pc_machine_initfn(Object *obj)
>       pcms->vmport = ON_OFF_AUTO_OFF;
>   #endif /* CONFIG_VMPORT */
>       pcms->max_ram_below_4g = 0; /* use default */
> -    pcms->smbios_entry_point_type = SMBIOS_ENTRY_POINT_TYPE_32;
> +    pcms->smbios_entry_point_type = pcmc->default_smbios_ep_type;

Ah, I missed this part. Thanks for suggestions. I'll send out v6.

Suravee

>       /* acpi build is enabled by default if machine supports it */
>       pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
> @@ -1979,6 +1979,7 @@ static void pc_machine_class_init(ObjectClass *oc, void 
> *data)
>       mc->nvdimm_supported = true;
>       mc->smp_props.dies_supported = true;
>       mc->default_ram_id = "pc.ram";
> +    mc->default_smbios_ep_type = SMBIOS_ENTRY_POINT_TYPE_64;
>   
>       object_class_property_add(oc, PC_MACHINE_MAX_RAM_BELOW_4G, "size",
>           pc_machine_get_max_ram_below_4g, pc_machine_set_max_ram_below_4g,