[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libguestfs] [PATCH v4 05/24] nbd: s/handle/cookie/ to match NBD spe
From: |
Eric Blake |
Subject: |
Re: [Libguestfs] [PATCH v4 05/24] nbd: s/handle/cookie/ to match NBD spec |
Date: |
Thu, 8 Jun 2023 09:32:44 -0500 |
User-agent: |
NeoMutt/20230517 |
On Thu, Jun 08, 2023 at 08:56:34AM -0500, Eric Blake wrote:
> Externally, libnbd exposed the 64-bit opaque marker for each client
> NBD packet as the "cookie", because it was less confusing when
> contrasted with 'struct nbd_handle *' holding all libnbd state. It
> also avoids confusion between the nown 'handle' as a way to identify a
noun
> packet and the verb 'handle' for reacting to things like signals.
> Upstream NBD changed their spec to favor the name "cookie" based on
> libnbd's recommendations[1], so we can do likewise.
>
> [1] https://github.com/NetworkBlockDevice/nbd/commit/ca4392eb2b
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v4 00/24] qemu patches for 64-bit NBD extensions, Eric Blake, 2023/06/08
- [PATCH v4 02/24] nbd: Consistent typedef usage in header, Eric Blake, 2023/06/08
- [PATCH v4 03/24] nbd/server: Prepare for alternate-size headers, Eric Blake, 2023/06/08
- [PATCH v4 04/24] nbd/server: Refactor to pass full request around, Eric Blake, 2023/06/08
- [PATCH v4 05/24] nbd: s/handle/cookie/ to match NBD spec, Eric Blake, 2023/06/08
- [PATCH v4 08/24] nbd: Use enum for various negotiation modes, Eric Blake, 2023/06/08
- [PATCH v4 06/24] nbd/client: Simplify cookie vs. index computation, Eric Blake, 2023/06/08
- [PATCH v4 14/24] nbd/server: Prepare to receive extended header requests, Eric Blake, 2023/06/08
- [PATCH v4 17/24] nbd/server: Enable initial support for extended headers, Eric Blake, 2023/06/08