Re: [PATCH] linux-user: Return EINVAL for getgroups() with negative gidsetsize

[Michael Tokarev]

03.06.2023 20:11, Michael Tokarev wrote:
> 02.06.2023 20:48, Peter Maydell wrote:
>
> > @@ -11574,7 +11574,7 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int 
> > num, abi_long arg1,
> >               g_autofree gid_t *grouplist = NULL;
> >               int i;
> > -            if (gidsetsize > NGROUPS_MAX) {
> > +            if (gidsetsize > NGROUPS_MAX || gidsetsize < 0) {
> >                   return -TARGET_EINVAL;
> >               }
> >               if (gidsetsize > 0) {
>
> FWIW, there's another piece of code exactly like this one,
> for TARGET_NR_getgroups32.  The same change is needed there too.

Peter, will you respin this (to include getgroups32 case), or should I ?
(The change is trivial enough to carry though -trivial@).

Thanks,

/mjt