Re: [PATCH v5 4/5] parallels: Replace fprintf by qemu_log in check

[Alexander Ivanov]

On 6/2/23 16:48, Hanna Czenczek wrote:
> On 29.05.23 17:15, Alexander Ivanov wrote:
> > If the check is called during normal work, tracking of the check must be
> > present in VM logs to have some clues if something going wrong with 
> > user's
> > data.
>
> I understand stderr counts as part of the VM log, doesn’t it?  I 
> thought stderr is generally logged, and naïvely, it seems like the 
> better fit to me, because it conveys more urgency than the standard 
> log (which, judging from its callers, looks mostly like a debug log).
>
> Hanna
We want to add some image checks to parallels_open(). It means that it 
will be used not only in qemu-img and we may lose these messages if a 
log file is specified. Stderr is not duplicated to the log file.
> > Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> > Reviewed-by: Denis V. Lunev <den@openvz.org>
> > ---
> >   block/parallels.c | 18 +++++++++---------
> >   1 file changed, 9 insertions(+), 9 deletions(-)

--
Best regards,
Alexander Ivanov