[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 00/18] target/riscv, KVM: fixes and enhancements
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v2 00/18] target/riscv, KVM: fixes and enhancements |
Date: |
Tue, 13 Jun 2023 17:58:39 -0300 |
Hi,
In this new version a lot of changes were made in the second half of the
series, all based on Andrew's feeback in v1.
Most notable changes are focused on reducing code repetition:
- a new misa_ext_infos[] array that holds 'name' and 'description' info
for MISA extensions to be shared between TCG and KVM code;
- 'KVMCPUConfig', a common struct used for both MISA and multi-letter KVM
extensions to store extension state;
- we're not adding a KVM specific riscv_isa_string_ext() function
anymore. A few tweaks are made to allow the same function to be used
for both TCG and KVM
Another notable change is on the last patch, where a lot of complexity
were removed by treating cbom/z blocksizes in a similar manner we deal
with machine-id properties: fetch their value at init() time and
validate the value in the set() accessor to fail early.
Patches missing review: 9-15, 17-18
Changes from v1:
- patch 11 (NEW):
- move code from riscv/cpu.c to cpu.h to create a MisaExtInfo array
- patch 17 (NEW):
- create a helper to retrieve the pointer address of a given cpu->cfg
attribute in a KVMCPUConfig element
- patch 1:
- renamed riscv_running_KVM() to riscv_running_kvm()
- patches 3,4,5:
- added get() accessors for machine-id properties
- patch 12 (former 11):
- use new MisaExtInfo instead of duplicating names and descriptions
- renamed RISCVCPUMisaExtConfig to KVMCPUConfig
- KVMCPUConfig is now generic and used by both MISA and multi-letter
extensions
- patch 13 (former 12):
- removed the -EINVAL check. Always error out if an error happens when
disabling a MISA extension
- patch 15 (former 14):
- kvm_riscv_isa_string_ext() was removed
- add 'kvm_available' in isa_ext_data struct
- added a new ISA_EXT_DATA_ENTRY_KVM() to set the added flag for
extensions that kvm is aware of
- added env->priv_ver = PRIV_VERSION_LATEST in riscv_host_cpu_init()
- patch 18 (former 16):
- all cbomz_blocksize logic was moved from realize() to init() time
- create a named KVMCPUConfig for each blocksize instead of adding
them in a separated array
- read blocksizes during init() time using the scratch KVM CPU
- validation moved to the property set() handler
- v1 link: https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg07779.html
Daniel Henrique Barboza (18):
target/riscv: skip features setup for KVM CPUs
hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set
target/riscv/cpu.c: restrict 'mvendorid' value
target/riscv/cpu.c: restrict 'mimpid' value
target/riscv/cpu.c: restrict 'marchid' value
target/riscv: use KVM scratch CPUs to init KVM properties
target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids()
target/riscv: handle mvendorid/marchid/mimpid for KVM CPUs
linux-headers: Update to v6.4-rc1
target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU
target/riscv/cpu: add misa_ext_infos[]
target/riscv: add KVM specific MISA properties
target/riscv/kvm.c: update KVM MISA bits
target/riscv/kvm.c: add multi-letter extension KVM properties
target/riscv: make riscv_isa_string_ext() KVM compatible
target/riscv: update multi-letter extension KVM properties
target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper
target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM
hw/riscv/virt.c | 14 +-
include/standard-headers/linux/const.h | 2 +-
include/standard-headers/linux/virtio_blk.h | 18 +-
.../standard-headers/linux/virtio_config.h | 6 +
include/standard-headers/linux/virtio_net.h | 1 +
linux-headers/asm-arm64/kvm.h | 33 ++
linux-headers/asm-riscv/kvm.h | 53 +-
linux-headers/asm-riscv/unistd.h | 9 +
linux-headers/asm-s390/unistd_32.h | 1 +
linux-headers/asm-s390/unistd_64.h | 1 +
linux-headers/asm-x86/kvm.h | 3 +
linux-headers/linux/const.h | 2 +-
linux-headers/linux/kvm.h | 12 +-
linux-headers/linux/psp-sev.h | 7 +
linux-headers/linux/userfaultfd.h | 17 +-
target/riscv/cpu.c | 261 +++++++--
target/riscv/cpu.h | 22 +-
target/riscv/kvm.c | 502 +++++++++++++++++-
target/riscv/kvm_riscv.h | 1 +
19 files changed, 878 insertions(+), 87 deletions(-)
--
2.40.1
- [PATCH v2 00/18] target/riscv, KVM: fixes and enhancements,
Daniel Henrique Barboza <=
- [PATCH v2 01/18] target/riscv: skip features setup for KVM CPUs, Daniel Henrique Barboza, 2023/06/13
- [PATCH v2 02/18] hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set, Daniel Henrique Barboza, 2023/06/13
- [PATCH v2 03/18] target/riscv/cpu.c: restrict 'mvendorid' value, Daniel Henrique Barboza, 2023/06/13
- [PATCH v2 04/18] target/riscv/cpu.c: restrict 'mimpid' value, Daniel Henrique Barboza, 2023/06/13
- [PATCH v2 05/18] target/riscv/cpu.c: restrict 'marchid' value, Daniel Henrique Barboza, 2023/06/13
- [PATCH v2 06/18] target/riscv: use KVM scratch CPUs to init KVM properties, Daniel Henrique Barboza, 2023/06/13
- [PATCH v2 07/18] target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids(), Daniel Henrique Barboza, 2023/06/13