qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 22/26] target/arm/tcg: Reduce 'helper-m.h.inc' inclusion


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 22/26] target/arm/tcg: Reduce 'helper-m.h.inc' inclusion
Date: Wed, 14 Jun 2023 14:37:47 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2

On 14/6/23 06:55, Richard Henderson wrote:
On 6/11/23 10:58, Philippe Mathieu-Daudé wrote:
+++ b/target/arm/tcg/translate.c
@@ -37,6 +37,11 @@
  #include "exec/helper-gen.h.inc"
  #undef  HELPER_H
+#define HELPER_H "tcg/helper-m.h.inc"
+#include "exec/helper-proto.h.inc"
+#include "exec/helper-gen.h.inc"
+#undef  HELPER_H

You don't need helper-proto.h here do you?

Right, rebase left-over...

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]