qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] hw/net/i82596: Include missing 'exec/address-spaces.h' h


From: Richard Henderson
Subject: Re: [PATCH 1/4] hw/net/i82596: Include missing 'exec/address-spaces.h' header
Date: Mon, 19 Jun 2023 10:05:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 6/19/23 09:41, Philippe Mathieu-Daudé wrote:
hw/net/i82596.c access the global 'address_space_memory'
calling the ld/st_phys() API. address_space_memory is
declared in "exec/address-spaces.h". Currently this header
is indirectly pulled in via another header. Explicitly include
it to avoid when refactoring unrelated headers:

   hw/net/i82596.c:91:23: error: use of undeclared identifier 
'address_space_memory'; did you mean 'address_space_destroy'?
     return ldub_phys(&address_space_memory, addr);
                       ^~~~~~~~~~~~~~~~~~~~
                       address_space_destroy

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
---
  hw/net/i82596.c | 1 +
  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]