[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/33] hw/sd/allwinner-sdhost: Don't send non-boolean IRQ line lev
From: |
Peter Maydell |
Subject: |
[PULL 25/33] hw/sd/allwinner-sdhost: Don't send non-boolean IRQ line levels |
Date: |
Mon, 19 Jun 2023 15:29:06 +0100 |
QEMU allows qemu_irq lines to transfer arbitrary integers. However
the convention is that for a simple IRQ line the values transferred
are always 0 and 1. The A10 SD controller device instead assumes a
0-vs-non-0 convention, which happens to work with the interrupt
controller it is wired up to.
Coerce the value to boolean to follow our usual convention.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Message-id: 20230606104609.3692557-3-peter.maydell@linaro.org
---
hw/sd/allwinner-sdhost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sd/allwinner-sdhost.c b/hw/sd/allwinner-sdhost.c
index 286e0095098..1a576d62ae2 100644
--- a/hw/sd/allwinner-sdhost.c
+++ b/hw/sd/allwinner-sdhost.c
@@ -193,7 +193,7 @@ static void allwinner_sdhost_update_irq(AwSdHostState *s)
}
trace_allwinner_sdhost_update_irq(irq);
- qemu_set_irq(s->irq, irq);
+ qemu_set_irq(s->irq, !!irq);
}
static void allwinner_sdhost_update_transfer_cnt(AwSdHostState *s,
--
2.34.1
- [PULL 13/33] target/arm: Convert load reg (literal) group to decodetree, (continued)
- [PULL 13/33] target/arm: Convert load reg (literal) group to decodetree, Peter Maydell, 2023/06/19
- [PULL 05/33] target/arm: Convert hint instruction space to decodetree, Peter Maydell, 2023/06/19
- [PULL 09/33] target/arm: Convert MSR (reg), MRS, SYS, SYSL to decodetree, Peter Maydell, 2023/06/19
- [PULL 11/33] target/arm: Convert load/store exclusive and ordered to decodetree, Peter Maydell, 2023/06/19
- [PULL 10/33] target/arm: Convert exception generation instructions to decodetree, Peter Maydell, 2023/06/19
- [PULL 08/33] target/arm: Convert MSR (immediate) to decodetree, Peter Maydell, 2023/06/19
- [PULL 15/33] target/arm: Convert ld/st reg+imm9 insns to decodetree, Peter Maydell, 2023/06/19
- [PULL 14/33] target/arm: Convert load/store-pair to decodetree, Peter Maydell, 2023/06/19
- [PULL 16/33] target/arm: Convert LDR/STR with 12-bit immediate to decodetree, Peter Maydell, 2023/06/19
- [PULL 18/33] target/arm: Convert atomic memory ops to decodetree, Peter Maydell, 2023/06/19
- [PULL 25/33] hw/sd/allwinner-sdhost: Don't send non-boolean IRQ line levels,
Peter Maydell <=
- [PULL 19/33] target/arm: Convert load (pointer auth) insns to decodetree, Peter Maydell, 2023/06/19
- [PULL 31/33] hw/misc/bcm2835_property: Use 'raspberrypi-fw-defs.h' definitions, Peter Maydell, 2023/06/19
- [PULL 22/33] target/arm: Convert load/store single structure to decodetree, Peter Maydell, 2023/06/19
- [PULL 23/33] target/arm: Convert load/store tags insns to decodetree, Peter Maydell, 2023/06/19
- [PULL 30/33] hw/arm/raspi: Import Linux raspi definitions as 'raspberrypi-fw-defs.h', Peter Maydell, 2023/06/19
- [PULL 28/33] imx_serial: set wake bit when we receive a data byte, Peter Maydell, 2023/06/19
- [PULL 29/33] docs: sbsa: document board to firmware interface, Peter Maydell, 2023/06/19
- [PULL 33/33] hw/misc/bcm2835_property: Handle CORE_CLK_ID firmware property, Peter Maydell, 2023/06/19
- [PULL 17/33] target/arm: Convert LDR/STR reg+reg to decodetree, Peter Maydell, 2023/06/19
- [PULL 24/33] hw/intc/allwinner-a10-pic: Handle IRQ levels other than 0 or 1, Peter Maydell, 2023/06/19