Re: [PATCH v3 22/34] target/arm/tcg: Reduce 'helper-crypto.h.inc' inclusion

[Philippe Mathieu-Daudé]

On 20/6/23 12:38, Richard Henderson wrote:
> On 6/19/23 17:54, Philippe Mathieu-Daudé wrote:
> > +++ b/target/arm/tcg/crypto_helper.c
> > @@ -12,12 +12,17 @@
> >   #include "qemu/osdep.h"
> >   #include "cpu.h"
> > -#include "exec/helper-proto.h"
> >   #include "tcg/tcg-gvec-desc.h"
> >   #include "crypto/aes.h"
> >   #include "crypto/sm4.h"
> >   #include "vec_internal.h"
> > +#define HELPER_H "tcg/helper-crypto.h.inc"
> > +#include "exec/helper-proto.h.inc"
> > +#include "exec/helper-gen.h.inc"
> > +#include "exec/helper-info.c.inc"
> > +#undef  HELPER_H
> > +
>
> foo_helper.c does not require helper-gen.h.inc.

Right.

> Usually we put helper-info.c.inc into one of the translate*.c files; 
> probably translate-neon.c in this case.

Yes.