qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] hw/i386: Remove unuseful kvmclock_create() stub


From: Alex Bennée
Subject: Re: [PATCH 1/2] hw/i386: Remove unuseful kvmclock_create() stub
Date: Tue, 20 Jun 2023 13:32:50 +0100
User-agent: mu4e 1.11.6; emacs 29.0.92

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> We shouldn't call kvmclock_create() when KVM is not available
> or disabled:
>  - check for kvm_enabled() before calling it
>  - assert KVM is enabled once called
> Since the call is elided when KVM is not available, we can
> remove the stub (it is never compiled).
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]