[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/42] migration-test: Update test_ignore_shared to use args
From: |
Peter Xu |
Subject: |
Re: [PATCH 11/42] migration-test: Update test_ignore_shared to use args |
Date: |
Tue, 20 Jun 2023 11:21:27 -0400 |
On Fri, Jun 09, 2023 at 12:49:12AM +0200, Juan Quintela wrote:
> It missed this treatment:
>
> commit 11f1a4ce14803f15d59cff42a4cfb7ac50d36bd0
> Author: Juan Quintela <quintela@redhat.com>
> Date: Mon Nov 29 18:57:51 2021 +0100
>
> migration-test: Check for shared memory like for everything else
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
This is still under "#if 0" block.. and the old code doesn't even compile,
but the change looks fine.
Reviewed-by: Peter Xu <peterx@redhat.com>
> ---
> tests/qtest/migration-test.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 743aa873e6..7178c8e679 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1597,8 +1597,11 @@ static void test_ignore_shared(void)
> {
> g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
> QTestState *from, *to;
> + MigrateStart args = {
> + .use_shmem = true
> + };
>
> - if (test_migrate_start(&from, &to, uri, false, true, NULL, NULL)) {
> + if (test_migrate_start(&from, &to, uri, &args)) {
> return;
> }
>
> --
> 2.40.1
>
--
Peter Xu
- Re: [PATCH 06/42] migration-test: machine_opts is really arch specific, (continued)
- [PATCH 08/42] migration-test: bootpath is the same for all tests and for all archs, Juan Quintela, 2023/06/08
- [PATCH 07/42] migration-test: Create kvm_opts, Juan Quintela, 2023/06/08
- [PATCH 09/42] migration-test: Add bootfile_create/delete() functions, Juan Quintela, 2023/06/08
- [PATCH 10/42] migration-test: dirtylimit checks for x86_64 arch before, Juan Quintela, 2023/06/08
- [PATCH 11/42] migration-test: Update test_ignore_shared to use args, Juan Quintela, 2023/06/08
- Re: [PATCH 11/42] migration-test: Update test_ignore_shared to use args,
Peter Xu <=
- [PATCH 12/42] migration-test: Enable back ignore-shared test, Juan Quintela, 2023/06/08
[PATCH 13/42] migration-test: Check for shared memory like for everything else, Juan Quintela, 2023/06/08