Re: [RFC PATCH] qemu-keymap: properly check return from xkb_keymap_mod_get_index

[Richard Henderson]

On 6/20/23 17:37, Alex Bennée wrote:
> ar maybe? it only got flagged in clang-system once fedora was updated (I
> assume with better sanitizers):
>
>    [2773/3696] Generating pc-bios/keymaps/ar with a custom command
>    FAILED: pc-bios/keymaps/ar
>    /builds/stsquad/qemu/build/qemu-keymap -f pc-bios/keymaps/ar -l ar
>    ../qemu-keymap.c:223:16: runtime error: shift exponent 4294967295 is too 
> large for 32-bit type 'int'
>    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior 
> ../qemu-keymap.c:223:16 in
>    [2774/3696] Generating pc-bios/edk2-x86_64-code.fd with a custom command 
> (wrapped by meson to capture output)
>    [2775/3696] Generating pc-bios/edk2-x86_64-secure-code.fd with a custom 
> command (wrapped by meson to capture output)
>    ninja: build stopped: subcommand failed.
>    make: *** [Makefile:153: run-ninja] Error 1
>
> https://gitlab.com/stsquad/qemu/-/jobs/4500683186#L3957

Related:

https://gitlab.com/qemu-project/qemu/-/issues/1709
https://gitlab.com/qemu-project/qemu/-/issues/1712

which note that keymaps/ar has changed to keymaps/ara in xkeyboard-config from 
2.38 to 2.39.


r~