Re: [PATCH v4 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI

[Leif Lindholm]

Hi Peter,

On 2023-06-19 13:47, Peter Maydell wrote:
> On Wed, 7 Jun 2023 at 03:34, Yuquan Wang <wangyuquan1236@phytium.com.cn> wrote:
> > The current sbsa-ref cannot use EHCI controller which is only
> > able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
> > Hence, this uses system bus XHCI to provide a usb controller with
> > 64-bit DMA capablity instead of EHCI.
>
> "capability"
>
> > Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
>
> The change itself looks good. We could probably mention in
> the commit message that existing firmware/kernel images
> still work (with no USB support) with this change.
>
> Is this the sort of change that we should increase the
> machine-version-minor for ? The comment says "updated
> when features are added that don't break fw compatibility"
> and this sounds like one of those.
>
> Leif, do you think we should bump the minor version here?

I think that makes sense, yes.

/
    Leif