[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 49/52] exec/poison: Do not poison CONFIG_SOFTMMU
From: |
Peter Maydell |
Subject: |
Re: [PULL 49/52] exec/poison: Do not poison CONFIG_SOFTMMU |
Date: |
Tue, 20 Jun 2023 19:01:21 +0100 |
On Mon, 5 Jun 2023 at 21:23, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> If CONFIG_USER_ONLY is ok generically, so is CONFIG_SOFTMMU,
> because they are exactly opposite.
This isn't quite right. CONFIG_USER_ONLY is theoretically
something we should poison, because it's unsafe in the general
case to use it in compiled-once source files. But in practice
we make quite a lot of use of it in "we know this specific
use of it is OK" situations, like ifdeffing out function
prototypes. So we'd like to poison it, but we can't poison
it without a huge amoun of refactoring which isn't really
worth the effort.
So it's not a good model for "therefore it's OK not to poison
CONFIG_SOFTMMU" -- we should leave that poisoned if we can,
so we don't introduce either new buggy uses of CONFIG_SOFTMMU,
or new "we know this is safe" uses of it which will make
it difficult to put it back into the poison-list later...
thanks
-- PMM
- [PULL 37/52] target/ppc: Inline gen_icount_io_start(), (continued)
- [PULL 37/52] target/ppc: Inline gen_icount_io_start(), Richard Henderson, 2023/06/05
- [PULL 42/52] target/arm: Add missing include of exec/exec-all.h, Richard Henderson, 2023/06/05
- [PULL 44/52] tcg: Fix PAGE/PROT confusion, Richard Henderson, 2023/06/05
- [PULL 45/52] tcg: Move env defines out of NEED_CPU_H in helper-head.h, Richard Henderson, 2023/06/05
- [PULL 40/52] target/mips: Tidy helpers for translation, Richard Henderson, 2023/06/05
- [PULL 41/52] target/*: Add missing includes of exec/translation-block.h, Richard Henderson, 2023/06/05
- [PULL 43/52] accel/tcg: Tidy includes for translator.[ch], Richard Henderson, 2023/06/05
- [PULL 46/52] tcg: Remove target-specific headers from tcg.[ch], Richard Henderson, 2023/06/05
- [PULL 47/52] plugins: Move plugin_insn_append to translator.c, Richard Henderson, 2023/06/05
- [PULL 49/52] exec/poison: Do not poison CONFIG_SOFTMMU, Richard Henderson, 2023/06/05
- Re: [PULL 49/52] exec/poison: Do not poison CONFIG_SOFTMMU,
Peter Maydell <=
- [PULL 50/52] tcg: Build once for system and once for user-only, Richard Henderson, 2023/06/05
- [PULL 52/52] tcg/tcg-op-vec: Remove left over _link_error() definitions, Richard Henderson, 2023/06/05
- [PULL 48/52] plugins: Drop unused headers from exec/plugin-gen.h, Richard Henderson, 2023/06/05
- [PULL 51/52] accel/tcg: Unmap perf_marker, Richard Henderson, 2023/06/05
- Re: [PULL 00/52] tcg patch queue, Richard Henderson, 2023/06/05