[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboa
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboard |
Date: |
Wed, 21 Jun 2023 08:09:12 +0100 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Tue, Jun 20, 2023 at 09:50:43PM +0200, Henrik Carlqvist wrote:
> On Tue, 20 Jun 2023 10:22:40 +0100
> Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Thanks for your feedback!
>
> > Assuming you have docutils installed, QEMU will build the manual by
> > default and print any issues on console during build. You can point
> > your browser to $BUILD/docs/manual/system/index.html to see the result.
>
> It seems as if I have docutils version 0.17.1 installed. However the
> build/docs directory only contains a symlink to the config directory in
> ../../docs after make is completed.
>
> > For future reference, if you want to put some questions/notes in the
> > submission, it is best to keep them separate from the commit message
> > text, as the questions/notes shouldn't end up in git history. To
> > separate them, put questions immediately after the '---' that separate
> > the commit message from the diffstat
>
> Thanks! Will do...
>
> > You need to remove the space between :ref: and `keyboard`.
> >
> > You'll also need to add it to a ToC (table of contents) otherwise
> > the build system complains.
> >
> > I'd suggest putting the new file at docs/system/devices/keyboards.rst
> > and adding to the ToC in docs/system/device-emulation.rst
>
> I will update the .rst files and placements, hopefully the coming weekend and
> come back with an updated patch. However, until I am able to build something
> from those .rst files, I can only follow your instructions to finally get them
> right.
If you're using one of the common Linux distros, you'll find a list of
the full set of packages you need to enable QEMU feuatres in the
dockerfiles at tests/docker/dockerfiles/. Those all have enough to
enable the docs build.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Ping: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/08
- Re: Ping: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard, Mark Cave-Ayland, 2023/06/10
- Re: Ping: [PATCH v6] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/10
- [PATCH v7] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/10
- Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboard, Daniel P . Berrangé, 2023/06/20
- Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/20
- Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboard,
Daniel P . Berrangé <=
- Re: [PATCH v7] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/21
- [PATCH v8] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/23
- Re: [PATCH v8] Emulate dip switch language layout settings on SUN keyboard, Daniel P . Berrangé, 2023/06/26
- Re: [PATCH v8] Emulate dip switch language layout settings on SUN keyboard, Mark Cave-Ayland, 2023/06/27
- Re: [PATCH v8] Emulate dip switch language layout settings on SUN keyboard, Henrik Carlqvist, 2023/06/27