[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH QEMU v6 1/9] softmmu/dirtylimit: Add parameter check for hmp "set
From: |
~hyman |
Subject: |
[PATCH QEMU v6 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" |
Date: |
Wed, 21 Jun 2023 07:24:20 -0000 |
From: Hyman Huang(黄勇) <yong.huang@smartx.com>
dirty_rate paraemter of hmp command "set_vcpu_dirty_limit" is invalid
if less than 0, so add parameter check for it.
Note that this patch also delete the unsolicited help message and
clean up the code.
Signed-off-by: Hyman Huang(黄勇) <yong.huang@smartx.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
---
softmmu/dirtylimit.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/softmmu/dirtylimit.c b/softmmu/dirtylimit.c
index 015a9038d1..5c12d26d49 100644
--- a/softmmu/dirtylimit.c
+++ b/softmmu/dirtylimit.c
@@ -515,14 +515,15 @@ void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict
*qdict)
int64_t cpu_index = qdict_get_try_int(qdict, "cpu_index", -1);
Error *err = NULL;
- qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err);
- if (err) {
- hmp_handle_error(mon, err);
- return;
+ if (dirty_rate < 0) {
+ error_setg(&err, "invalid dirty page limit %ld", dirty_rate);
+ goto out;
}
- monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query "
- "dirty limit for virtual CPU]\n");
+ qmp_set_vcpu_dirty_limit(!!(cpu_index != -1), cpu_index, dirty_rate, &err);
+
+out:
+ hmp_handle_error(mon, err);
}
static struct DirtyLimitInfo *dirtylimit_query_vcpu(int cpu_index)
--
2.38.5
- [PATCH QEMU v6 0/9] migration: introduce dirtylimit capability, ~hyman, 2023/06/21
- [PATCH QEMU v6 4/9] migration: Introduce dirty-limit capability, ~hyman, 2023/06/21
- [PATCH QEMU v6 3/9] qapi/migration: Introduce vcpu-dirty-limit parameters, ~hyman, 2023/06/21
- [PATCH QEMU v6 6/9] migration: Put the detection logic before auto-converge checking, ~hyman, 2023/06/21
- [PATCH QEMU v6 7/9] migration: Implement dirty-limit convergence algo, ~hyman, 2023/06/21
- [PATCH QEMU v6 2/9] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter, ~hyman, 2023/06/21
- [PATCH QEMU v6 1/9] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit",
~hyman <=
- [PATCH QEMU v6 5/9] migration: Refactor auto-converge capability logic, ~hyman, 2023/06/21
- [PATCH QEMU v6 8/9] migration: Extend query-migrate to provide dirty page limit info, ~hyman, 2023/06/21
- [PATCH QEMU v6 9/9] tests: Add migration dirty-limit capability test, ~hyman, 2023/06/21