[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 2/5] parallels: Check if data_end greater than the file size
From: |
Alexander Ivanov |
Subject: |
[PATCH v6 2/5] parallels: Check if data_end greater than the file size |
Date: |
Wed, 21 Jun 2023 10:20:07 +0200 |
Initially data_end is set to the data_off image header field and must not be
greater than the file size.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/block/parallels.c b/block/parallels.c
index 1ec98c722b..4b7eafba1e 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -868,6 +868,11 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
and actual data. We can't avoid read-modify-write... */
s->header_size = size;
}
+ if (s->data_end > file_nb_sectors) {
+ error_setg(errp, "Invalid image: incorrect data_off field");
+ ret = -EINVAL;
+ goto fail;
+ }
ret = bdrv_pread(bs->file, 0, s->header_size, s->header, 0);
if (ret < 0) {
--
2.34.1
- [PATCH v6 0/5] parallels: Add duplication check, repair at open, fix bugs, Alexander Ivanov, 2023/06/21
- [PATCH v6 1/5] parallels: Incorrect data end calculation in parallels_open(), Alexander Ivanov, 2023/06/21
- [PATCH v6 2/5] parallels: Check if data_end greater than the file size,
Alexander Ivanov <=
- [PATCH v6 3/5] parallels: Add change_info argument to parallels_check_leak(), Alexander Ivanov, 2023/06/21
- [PATCH v6 5/5] parallels: Image repairing in parallels_open(), Alexander Ivanov, 2023/06/21
- [PATCH v6 4/5] parallels: Add checking and repairing duplicate offsets in BAT, Alexander Ivanov, 2023/06/21
- Re: [PATCH v6 0/5] parallels: Add duplication check, repair at open, fix bugs, Denis V. Lunev, 2023/06/21