[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tests/plugin: Remove duplicate insn log from libinsn.so
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2] tests/plugin: Remove duplicate insn log from libinsn.so |
Date: |
Wed, 21 Jun 2023 11:17:43 +0100 |
User-agent: |
mu4e 1.11.6; emacs 29.0.92 |
Richard Henderson <richard.henderson@linaro.org> writes:
> This is a perfectly natural occurrence for x86 "rep movb",
> where the "rep" prefix forms a counted loop of the one insn.
>
> During the tests/tcg/multiarch/memory test, this logging is
> triggered over 350000 times. Within the context of cross-i386-tci
> build, which is already slow by nature, the logging is sufficient
> to push the test into timeout.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/tcg/i386/Makefile.softmmu-target | 9 ---------
> tests/tcg/i386/Makefile.target | 6 ------
> tests/tcg/x86_64/Makefile.softmmu-target | 9 ---------
> 3 files changed, 24 deletions(-)
I suspect this wasn't squashed into the changes to insn.c itself.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro