Re: [PATCH 16/42] migration-test: Create do_migrate()

[Juan Quintela]

Peter Xu <peterx@redhat.com> wrote:
> On Fri, Jun 09, 2023 at 12:49:17AM +0200, Juan Quintela wrote:
>> We called migrate_qmp() in lot of places.  And there are tricks like
>> changing tcp address with the right port.
>> 
>> Only two callers remaining:
>> - postcopy resume: It needs to play with the qmp.
>> - baddest: We want to do a unvalid URI. For that we need to do it by
>>   hand.
>> -    uri = migrate_get_socket_address(to, "socket-address");
>> -
>> -    migrate_qmp(from, uri, "{}");
>> +    do_migrate(from, to, "127.0.0.1:0");
>
> I think this means migrating to "127.0.0.1:0".  Can this work?

You are right.

do_migrate(from, to, NULL)

Same for the next one.

Too many rebases trying to make things clearer.

Good catch.