[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/18] migration: RDMA is not compatible with anything else
From: |
Lukas Straub |
Subject: |
Re: [PATCH 03/18] migration: RDMA is not compatible with anything else |
Date: |
Thu, 22 Jun 2023 13:44:27 +0200 |
On Tue, 13 Jun 2023 16:57:42 +0200
Juan Quintela <quintela@redhat.com> wrote:
> So give an error instead of just ignoring the other methods.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
> ---
> migration/migration.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index dc05c6f6ea..84551f040c 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -436,6 +436,18 @@ static void qemu_start_incoming_migration(const char
> *uri, Error **errp)
> socket_start_incoming_migration(p ? p : uri, errp);
> #ifdef CONFIG_RDMA
> } else if (strstart(uri, "rdma:", &p)) {
> + if (migrate_compress()) {
> + error_setg(errp, "RDMA and compression can't be used together");
> + return;
> + }
> + if (migrate_xbzrle()) {
> + error_setg(errp, "RDMA and XBZRLE can't be used together");
> + return;
> + }
> + if (migrate_multifd()) {
> + error_setg(errp, "RDMA and multifd can't be used together");
> + return;
> + }
> rdma_start_incoming_migration(p, errp);
> #endif
> } else if (strstart(uri, "exec:", &p)) {
pgpZA5eoeLdZL.pgp
Description: OpenPGP digital signature
- [PATCH 00/18] Migration compression cleanup, Juan Quintela, 2023/06/13
- [PATCH 01/18] migration: Give one error if trying to set MULTIFD and XBZRLE, Juan Quintela, 2023/06/13
- [PATCH 04/18] migration: Remove save_page_use_compression(), Juan Quintela, 2023/06/13
- [PATCH 07/18] migration: Create ram_compressed_pages(), Juan Quintela, 2023/06/13
- [PATCH 03/18] migration: RDMA is not compatible with anything else, Juan Quintela, 2023/06/13
- Re: [PATCH 03/18] migration: RDMA is not compatible with anything else,
Lukas Straub <=
- [PATCH 02/18] migration: Give one error if trying to set COMPRESSION and XBZRLE, Juan Quintela, 2023/06/13
- [PATCH 08/18] migration: Move update_compress_threads_counts() to ram-compress.c, Juan Quintela, 2023/06/13
- [PATCH 09/18] migration: Make compress_data_with_multithreads return bool, Juan Quintela, 2023/06/13
- [PATCH 06/18] migration: Create populate_compress(), Juan Quintela, 2023/06/13
- [PATCH 10/18] migration: Simplify compress_page_with_multithread(), Juan Quintela, 2023/06/13