[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index |
|
Date: |
Fri, 23 Jun 2023 13:25:10 +0100 |
On Fri, 23 Jun 2023 at 13:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> We can return XKB_MOD_INVALID which rightly gets flagged by sanitisers
> as an overly wide shift attempt.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Same comments as on the first version of this patch:
looks OK code-wise, but have you eyeballed the output?
Does the keyboard layout that triggers this have no
AltGr at all, or does it call it by a different name?
thanks
-- PMM
- [PATCH 00/26] maintainer omnibus: testing, fuzz, plugins, documentation, Alex Bennée, 2023/06/23
- [PATCH 12/26] tests/lcitool: update to latest version, Alex Bennée, 2023/06/23
- [PATCH 13/26] tests/lcitool: Bump fedora container versions, Alex Bennée, 2023/06/23
- [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index, Alex Bennée, 2023/06/23
- Re: [PATCH 07/26] qemu-keymap: properly check return from xkb_keymap_mod_get_index,
Peter Maydell <=
- [PATCH 04/26] docs/devel: remind developers to run CI container pipeline when updating images, Alex Bennée, 2023/06/23
- [PATCH 03/26] gitlab: reduce testing scope of check-gcov, Alex Bennée, 2023/06/23
- [PATCH 02/26] gitlab: ensure coverage job also publishes meson log, Alex Bennée, 2023/06/23
- [PATCH 14/26] tests/lcitool: add an explicit gcc-native package, Alex Bennée, 2023/06/23
- [PATCH 10/26] tests/docker: add test-fuzz, Alex Bennée, 2023/06/23
- [PATCH 16/26] tests/docker: convert riscv64-cross to lcitool, Alex Bennée, 2023/06/23