Re: [PULL 19/21] target/hexagon: import parser for idef-parser

[Peter Maydell]

On Fri, 16 Dec 2022 at 20:51, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> From: Anton Johansson <anjo@rev.ng>
>
> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
> Signed-off-by: Paolo Montesel <babush@rev.ng>
> Signed-off-by: Anton Johansson <anjo@rev.ng>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
> Message-Id: <20220923173831.227551-10-anjo@rev.ng>

Hi; Coverity points out (CID 976926) that here:

> --- /dev/null
> +++ b/target/hexagon/idef-parser/idef-parser.y

> +lvalue : FAIL
> +         {
> +             @1.last_column = @1.last_column;

...we have coded an "x = x" assignment that has no
effect. Was this supposed to be something else, or should it
just be deleted?

> +             yyassert(c, &@1, false, "Encountered a FAIL token as 
> lvalue.\n");
> +         }
> +       | REG
> +         {
> +             $$ = $1;
> +         }
> +       | var
> +         {
> +             $$ = $1;
> +         }
> +       ;

thanks
-- PMM