[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 2/9] hw/net: vmxnet3: Remove the logic of padding short frames
From: |
Bin Meng |
Subject: |
[PATCH v7 2/9] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path |
Date: |
Sun, 25 Jun 2023 09:53:14 +0800 |
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---
(no changes since v1)
hw/net/vmxnet3.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 18b9edfdb2..5dfacb1098 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -40,7 +40,6 @@
#define PCI_DEVICE_ID_VMWARE_VMXNET3_REVISION 0x1
#define VMXNET3_MSIX_BAR_SIZE 0x2000
-#define MIN_BUF_SIZE 60
/* Compatibility flags for migration */
#define VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS_BIT 0
@@ -1977,7 +1976,6 @@ vmxnet3_receive(NetClientState *nc, const uint8_t *buf,
size_t size)
{
VMXNET3State *s = qemu_get_nic_opaque(nc);
size_t bytes_indicated;
- uint8_t min_buf[MIN_BUF_SIZE];
if (!vmxnet3_can_receive(nc)) {
VMW_PKPRN("Cannot receive now");
@@ -1990,14 +1988,6 @@ vmxnet3_receive(NetClientState *nc, const uint8_t *buf,
size_t size)
size -= sizeof(struct virtio_net_hdr);
}
- /* Pad to minimum Ethernet frame length */
- if (size < sizeof(min_buf)) {
- memcpy(min_buf, buf, size);
- memset(&min_buf[size], 0, sizeof(min_buf) - size);
- buf = min_buf;
- size = sizeof(min_buf);
- }
-
net_rx_pkt_set_packet_type(s->rx_pkt,
get_eth_packet_type(PKT_GET_ETH_HDR(buf)));
--
2.34.1
- [PATCH v7 0/9] net: Pad short frames for network backends, Bin Meng, 2023/06/24
- [PATCH v7 8/9] hw/net: sunhme: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 5/9] hw/net: pcnet: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 1/9] hw/net: e1000: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 6/9] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 4/9] hw/net: ne2000: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 7/9] hw/net: sungem: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 2/9] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path,
Bin Meng <=
- [PATCH v7 3/9] hw/net: i82596: Remove the logic of padding short frames in the receive path, Bin Meng, 2023/06/24
- [PATCH v7 9/9] hw/net: ftgmac100: Drop the small packet check in the receive path, Bin Meng, 2023/06/24