qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S


From: Christian Borntraeger
Subject: Re: [PATCH 3/4] pc-bios/s390-ccw: Move the stack array into start.S
Date: Mon, 26 Jun 2023 16:54:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0


Am 26.06.23 um 15:21 schrieb Thomas Huth:

diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index 29b0a9ece0..47ef6e8aa8 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -120,3 +120,8 @@ external_new_mask:
      .quad   0x0000000180000000
  io_new_mask:
      .quad   0x0000000180000000
+
+.bss
+
+    .align  16
+    .lcomm  stack,STACK_SIZE

IIRC, the ELF ABI defines the stack to be 8 byte aligned, but 16 certainly does 
not hurt.

Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]