[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/4] pc-bios/s390-ccw: Fix indentation in start.S
|
From: |
Eric Farman |
|
Subject: |
Re: [PATCH v2 1/4] pc-bios/s390-ccw: Fix indentation in start.S |
|
Date: |
Tue, 27 Jun 2023 06:01:10 -0400 |
|
User-agent: |
Evolution 3.48.3 (3.48.3-1.fc38) |
On Tue, 2023-06-27 at 09:47 +0200, Thomas Huth wrote:
> start.S is currently indented with a mixture of spaces and tabs,
> which
> is quite ugly. QEMU coding style says indentation should be 4 spaces,
> and this is also what we are using in the assembler files in the
> tests/tcg/s390x/ folder already, so let's adjust start.S accordingly.
>
> Reviewed-by: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> pc-bios/s390-ccw/start.S | 136 +++++++++++++++++++------------------
> --
> 1 file changed, 68 insertions(+), 68 deletions(-)
Oh, that looks nice. Thank you.
Reviewed-by: Eric Farman <farman@linux.ibm.com>