|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [PATCH v4 22/24] nbd/server: Refactor list of negotiated meta contexts |
Date: | Tue, 27 Jun 2023 18:11:19 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 |
On 08.06.23 16:56, Eric Blake wrote:
Peform several minor refactorings of how the list of negotiated meta contexts is managed, to make upcoming patches easier: Promote the internal type NBDExportMetaContexts to the public opaque type NBDMetaContexts, and mark exp const. Use a shorter member name in NBDClient. Hoist calls to nbd_check_meta_context() earlier in their callers, as the number of negotiated contexts may impact the flags exposed in regards to an export, which in turn requires a new parameter.
Hmm, a bit of semantic change: we drop context in nbd_check_meta_export() even when we report error. Pre-patch we call nbd_check_meta_export() only on success path.. Still, it seems even more safe. Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Drop a redundant parameter to nbd_negotiate_meta_queries.
No semantic change intended. Signed-off-by: Eric Blake <eblake@redhat.com>
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |