Re: ARI and igb emulation

[Ani Sinha]

> On 28-Jun-2023, at 12:36 PM, Jason Wang <jasowang@redhat.com> wrote:
> 
> On Wed, Jun 28, 2023 at 3:01 PM Ani Sinha <anisinha@redhat.com> wrote:
>> 
>> 
>> 
>>> On 28-Jun-2023, at 12:23 PM, Jason Wang <jasowang@redhat.com> wrote:
>>> 
>>> On Tue, Jun 27, 2023 at 10:41 PM Ani Sinha <anisinha@redhat.com> wrote:
>>>> 
>>>> 
>>>> 
>>>>> On 27-Jun-2023, at 8:09 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
>>>>> 
>>>>> On Tue, Jun 27, 2023 at 08:02:46PM +0530, Ani Sinha wrote:
>>>>>> Hi :
>>>>>> I am proposing a patch in QEMU [1] which may or may not break ARI but I 
>>>>>> wanted to give my best shot in making sure I am not breaking anything 
>>>>>> with ARI enabled. I see that your igb emulation code enables ARI with 
>>>>>> its SRIOV emulation. I ran the qtest and avocado tests that are 
>>>>>> mentioned in [2] and they both pass. Is there anything else/any tweaks 
>>>>>> that I should be doing to make sure I am not breaking ARI with igb?
>>>>>> 
>>>>>> Thanks for information,
>>>>>> Ani
>>>>>> 
>>>>>> 1. https://lists.gnu.org/archive/html/qemu-devel/2023-06/msg05478.html
>>>>>> 2. https://www.qemu.org/docs/master/system/devices/igb.html
>>>>>> 
>>>>> 
>>>>> I think that just creates igb. to test ARI you need to add
>>>>> igbvf devices. Jason maintains it. But really pls go back on-list.
>>>> 
>>>> +Jason
>>>> +qemu-devel
>>>> 
>>> 
>>> Yes, you need to at least create VFS and test some throughput on it
>>> (probably need a vIOMMU).
>> 
>> Is there a test that I can run?
>> 
> 
> A simple netperf/iperf should be sufficient.

I meant a full test script that uses igb emulation with vfs etc. I really do 
not have time to set this whole thing up manually. Maybe something was used to 
test sriov and igb emulation while development and a test might have been 
committed in QEMU.