Re: [PATCH] i386/WHPX: Fix error message when fail to set ProcessorCount

[Zhao Liu]

On Wed, Jun 28, 2023 at 01:59:56PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Wed, 28 Jun 2023 13:59:56 +0200
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: Re: [PATCH] i386/WHPX: Fix error message when fail to set
>  ProcessorCount
> 
> On 29/5/23 14:43, Zhao Liu wrote:
> > From: Zhao Liu <zhao1.liu@intel.com>
> > 
> > 003f230e37d7 ("machine: Tweak the order of topology members in struct
> > CpuTopology") changes the meaning of MachineState.smp.cores from "the
> > number of cores in one package" to "the number of cores in one die"
> > and doesn't fix other uses of MachineState.smp.cores. And because of
> > the introduction of cluster, now smp.cores just means "the number of
> > cores in one cluster". This clearly does not fit the semantics here.
> > 
> > And before this error message, WHvSetPartitionProperty() is called to
> > set prop.ProcessorCount.
> > 
> > So the error message should show the prop.ProcessorCount other than
> > "cores per cluster" or "cores per package".
> > 
> > Cc: Sunil Muthuswamy <sunilmut@microsoft.com>
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> >   target/i386/whpx/whpx-all.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Patch queued (fixing the unsigned format), thanks.
>

Many thanks!

-Zhao