Re: [PATCH v2 2/2] vfio/migration: Make VFIO migration non-experimental

[Joao Martins]

On 28/06/2023 08:31, Avihai Horon wrote:
> The major parts of VFIO migration are supported today in QEMU. This
> includes basic VFIO migration, device dirty page tracking and precopy
> support.
> 
> Thus, at this point in time, it seems appropriate to make VFIO migration
> non-experimental: remove the x prefix from enable_migration property,
> change it to ON_OFF_AUTO and let the default value be AUTO.
> 
> In addition, make the following adjustments:
> 1. When enable_migration is ON and migration is not supported, fail VFIO
>    device realization.
> 2. When enable_migration is AUTO (i.e., not explicitly enabled), require
>    device dirty tracking support. This is because device dirty tracking
>    is currently the only method to do dirty page tracking, which is
>    essential for migrating in a reasonable downtime. Setting
>    enable_migration to ON will not require device dirty tracking.
> 3. Make migration error and blocker messages more elaborate.
> 4. Remove error prints in vfio_migration_query_flags().
> 5. Rename trace_vfio_migration_probe() to
>    trace_vfio_migration_realize().
> 
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>