[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/30] accel: Destroy HAX vCPU threads once done
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 07/30] accel: Destroy HAX vCPU threads once done |
Date: |
Wed, 28 Jun 2023 17:52:50 +0200 |
When the vCPU thread finished its processing, destroy
it and signal its destruction to generic vCPU management
layer.
Add a sanity check for the vCPU accelerator context.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230624174121.11508-6-philmd@linaro.org>
---
target/i386/hax/hax-accel-ops.c | 3 +++
target/i386/hax/hax-all.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/target/i386/hax/hax-accel-ops.c b/target/i386/hax/hax-accel-ops.c
index 18114fe34d..0157a628a3 100644
--- a/target/i386/hax/hax-accel-ops.c
+++ b/target/i386/hax/hax-accel-ops.c
@@ -53,6 +53,8 @@ static void *hax_cpu_thread_fn(void *arg)
qemu_wait_io_event(cpu);
} while (!cpu->unplug || cpu_can_run(cpu));
+ hax_vcpu_destroy(cpu);
+ cpu_thread_signal_destroyed(cpu);
rcu_unregister_thread();
return NULL;
}
@@ -69,6 +71,7 @@ static void hax_start_vcpu_thread(CPUState *cpu)
cpu->cpu_index);
qemu_thread_create(cpu->thread, thread_name, hax_cpu_thread_fn,
cpu, QEMU_THREAD_JOINABLE);
+ assert(cpu->hax_vcpu);
#ifdef _WIN32
cpu->hThread = qemu_thread_get_handle(cpu->thread);
#endif
diff --git a/target/i386/hax/hax-all.c b/target/i386/hax/hax-all.c
index a2321a1eff..38a4323a3c 100644
--- a/target/i386/hax/hax-all.c
+++ b/target/i386/hax/hax-all.c
@@ -209,6 +209,7 @@ int hax_vcpu_destroy(CPUState *cpu)
CloseHandle(cpu->hThread);
#endif
g_free(vcpu);
+ cpu->hax_vcpu = NULL;
return 0;
}
--
2.38.1
- [PULL 00/30] Accelerator patches for 2023-06-28, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 01/30] MAINTAINERS: Update Roman Bolshakov email address, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 02/30] docs/devel/testing: Update the 'Docker Debugging' section, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 03/30] accel: Re-enable WHPX cross-build on case sensitive filesystems, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 04/30] accel: Document generic accelerator headers, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 05/30] accel: Remove unused hThread variable on TCG/WHPX, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 06/30] accel: Fix a leak on Windows HAX, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 07/30] accel: Destroy HAX vCPU threads once done,
Philippe Mathieu-Daudé <=
- [PULL 08/30] accel: Rename 'hax_vcpu' as 'accel' in CPUState, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 09/30] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 10/30] accel: Move HAX hThread to accelerator context, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 11/30] accel: Remove NVMM unreachable error path, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 12/30] accel: Rename NVMM 'struct qemu_vcpu' -> AccelCPUState, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 13/30] accel: Inline NVMM get_qemu_vcpu(), Philippe Mathieu-Daudé, 2023/06/28
- [PULL 14/30] accel: Remove WHPX unreachable error path, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 15/30] accel: Rename WHPX 'struct whpx_vcpu' -> AccelCPUState, Philippe Mathieu-Daudé, 2023/06/28
- [PULL 17/30] accel: Rename 'cpu_state' -> 'cs', Philippe Mathieu-Daudé, 2023/06/28
- [PULL 16/30] accel: Inline WHPX get_whpx_vcpu(), Philippe Mathieu-Daudé, 2023/06/28