[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/16] hw/pci-host/q35: Fix double, contradicting .endianness
From: |
Bernhard Beschow |
Subject: |
[PATCH v2 02/16] hw/pci-host/q35: Fix double, contradicting .endianness assignment |
Date: |
Wed, 28 Jun 2023 21:51:50 +0200 |
Fixes the following clangd warning (-Winitializer-overrides):
q35.c:297:19: Initializer overrides prior initialization of this subobject
q35.c:292:19: previous initialization is here
Settle on little endian which is consistent with using pci_host_conf_le_ops.
Fixes: bafc90bdc594 ("q35: implement TSEG")
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
hw/pci-host/q35.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
index fd18920e7f..84137b9ad9 100644
--- a/hw/pci-host/q35.c
+++ b/hw/pci-host/q35.c
@@ -285,7 +285,6 @@ static void blackhole_write(void *opaque, hwaddr addr,
uint64_t val,
static const MemoryRegionOps blackhole_ops = {
.read = blackhole_read,
.write = blackhole_write,
- .endianness = DEVICE_NATIVE_ENDIAN,
.valid.min_access_size = 1,
.valid.max_access_size = 4,
.impl.min_access_size = 4,
--
2.41.0
- [PATCH v2 00/16] Q35 and I440FX host bridge QOM cleanup, Bernhard Beschow, 2023/06/28
- [PATCH v2 02/16] hw/pci-host/q35: Fix double, contradicting .endianness assignment,
Bernhard Beschow <=
- [PATCH v2 01/16] hw/i386/pc_q35: Resolve redundant q35_host variable, Bernhard Beschow, 2023/06/28
- [PATCH v2 03/16] hw/pci-host/q35: Initialize PCMachineState::bus in board code, Bernhard Beschow, 2023/06/28
- [PATCH v2 04/16] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro, Bernhard Beschow, 2023/06/28
- [PATCH v2 08/16] hw/pci-host/i440fx: Have common names for some local variables, Bernhard Beschow, 2023/06/28
- [PATCH v2 07/16] hw/pci-host/i440fx: Replace magic values by existing constants, Bernhard Beschow, 2023/06/28
- [PATCH v2 09/16] hw/pci-host/i440fx: Move i440fx_realize() into PCII440FXState section, Bernhard Beschow, 2023/06/28
- [PATCH v2 06/16] hw/pci-host/q35: Make some property name macros reusable by i440fx, Bernhard Beschow, 2023/06/28
- [PATCH v2 10/16] hw/pci-host/i440fx: Make MemoryRegion pointers accessible as properties, Bernhard Beschow, 2023/06/28