Re: [PATCH v6 15/20] target/riscv/cpu.c: add satp

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlie

From:	Philippe Mathieu-Daudé
Subject:	Re: [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlier
Date:	Thu, 29 Jun 2023 09:30:51 +0200
User-agent:	Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0

On 28/6/23 23:30, Daniel Henrique Barboza wrote:

riscv_cpu_add_user_properties() ended up with an excess of "#ifndef
CONFIG_USER_ONLY" blocks after changes that added KVM properties
handling.

KVM specific properties are required to be created earlier than their
TCG counterparts, but the remaining props can be created at any order.
Move riscv_add_satp_mode_properties() to the start of the function,
inside the !CONFIG_USER_ONLY block already present there, to remove the
last ifndef block.

Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
---
  target/riscv/cpu.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v6 10/20] target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU, (continued)
- [PATCH v6 10/20] target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU, Daniel Henrique Barboza, 2023/06/28
- [PATCH v6 11/20] target/riscv/cpu: add misa_ext_info_arr[], Daniel Henrique Barboza, 2023/06/28
  - Re: [PATCH v6 11/20] target/riscv/cpu: add misa_ext_info_arr[], Philippe Mathieu-Daudé, 2023/06/29
  - Re: [PATCH v6 11/20] target/riscv/cpu: add misa_ext_info_arr[], Andrew Jones, 2023/06/29
- [PATCH v6 12/20] target/riscv: add KVM specific MISA properties, Daniel Henrique Barboza, 2023/06/28
  - Re: [PATCH v6 12/20] target/riscv: add KVM specific MISA properties, Andrew Jones, 2023/06/29
- [PATCH v6 13/20] target/riscv/kvm.c: update KVM MISA bits, Daniel Henrique Barboza, 2023/06/28
- [PATCH v6 14/20] target/riscv/kvm.c: add multi-letter extension KVM properties, Daniel Henrique Barboza, 2023/06/28
  - Re: [PATCH v6 14/20] target/riscv/kvm.c: add multi-letter extension KVM properties, Andrew Jones, 2023/06/29
- [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlier, Daniel Henrique Barboza, 2023/06/28
  - Re: [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlier, Philippe Mathieu-Daudé <=
  - Re: [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlier, Andrew Jones, 2023/06/29
- [PATCH v6 16/20] target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext(), Daniel Henrique Barboza, 2023/06/28
- [PATCH v6 17/20] target/riscv/cpu.c: create KVM mock properties, Daniel Henrique Barboza, 2023/06/28
  - Re: [PATCH v6 17/20] target/riscv/cpu.c: create KVM mock properties, Andrew Jones, 2023/06/29
- [PATCH v6 19/20] target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper, Daniel Henrique Barboza, 2023/06/28
- [PATCH v6 18/20] target/riscv: update multi-letter extension KVM properties, Daniel Henrique Barboza, 2023/06/28
- [PATCH v6 20/20] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM, Daniel Henrique Barboza, 2023/06/28

Prev by Date: Re: [PATCH v6 11/20] target/riscv/cpu: add misa_ext_info_arr[]
Next by Date: Re: [PATCH] hw/ppc: Fix clock update drift
Previous by thread: [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlier
Next by thread: Re: [PATCH v6 15/20] target/riscv/cpu.c: add satp_mode properties earlier
Index(es):
- Date
- Thread